Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detect Vimball (.vba, .vmb) files as Vim script #4412

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

smola
Copy link
Contributor

@smola smola commented Feb 9, 2019

Fixes #501

Description

Checklist:

Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @smola for fixing this!

I left a few comments below.

samples/Vim script/textobj-rubyblock.vba Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/heuristics.yml Show resolved Hide resolved
test/test_heuristics.rb Outdated Show resolved Hide resolved
- added .vba and .vmb extensions to Vim script

- added .vba disambiguation

- added Vimball sample with .vba extension (Vim license) from https://github.com/nelstrom/vim-textobj-rubyblock/blob/master/textobj-rubyblock.vba

- added Vimball sample with .vmb extension (WTFPL) from https://github.com/CDSoft/todo/blob/master/todo.vmb

- added Visual Basic sample with .vba extension (MIT license) from https://github.com/Akaizoku/concatenate/blob/master/procedures.vba
Copy link
Contributor

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Alhadis added a commit to Alhadis/language-viml that referenced this pull request Feb 14, 2019
Alhadis added a commit to file-icons/atom that referenced this pull request Feb 14, 2019
@lildude lildude merged commit 602debc into github-linguist:master Mar 1, 2019
@smola smola deleted the vimball branch October 31, 2019 23:42
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.vba is not always Visual Basic
4 participants