-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
detect Vimball (.vba, .vmb) files as Vim script #4412
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
suggested changes
Feb 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @smola for fixing this!
I left a few comments below.
- added .vba and .vmb extensions to Vim script - added .vba disambiguation - added Vimball sample with .vba extension (Vim license) from https://github.com/nelstrom/vim-textobj-rubyblock/blob/master/textobj-rubyblock.vba - added Vimball sample with .vmb extension (WTFPL) from https://github.com/CDSoft/todo/blob/master/todo.vmb - added Visual Basic sample with .vba extension (MIT license) from https://github.com/Akaizoku/concatenate/blob/master/procedures.vba
pchaigno
approved these changes
Feb 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
Alhadis
approved these changes
Feb 14, 2019
Alhadis
added a commit
to Alhadis/language-viml
that referenced
this pull request
Feb 14, 2019
Alhadis
added a commit
to file-icons/atom
that referenced
this pull request
Feb 14, 2019
lildude
approved these changes
Mar 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #501
Description
Checklist: