Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate .simplecov file with Ruby #4976

Merged
merged 1 commit into from
Aug 30, 2020

Conversation

marcotc
Copy link
Contributor

@marcotc marcotc commented Aug 28, 2020

Associate the .simplecov configuration file to the Ruby language.

Description

.simplecov files are loaded as Ruby source code, thus must contain valid Ruby syntax.

They are currently unhighlighted for the most part: https://github.com/search?q=filename%3A.simplecov

Checklist:

  • I am associating a language with a new file name.
    • The new file name is used in hundreds of repositories on github.com
    • I have included a real-world usage sample for all file names added in this PR:
      • Sample source(s): samples/Ruby/filenames/.simplecov
      • Sample license(s): My own project. I agree to publish samples/Ruby/filenames/.simplecov under MIT.

Copy link
Collaborator

@Alhadis Alhadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks damn good to me. 👍

@Alhadis
Copy link
Collaborator

Alhadis commented Aug 28, 2020

@lildude This PR reminded me; Linguist could do with coverage generation, which would help us eliminate dead-code after a refactor, as opposed to letting it linger in our codebase for years.

Doesn't need to be done with .simplecov; whatever tooling Ruby programmers use for coverage reports will do.

@lildude
Copy link
Member

lildude commented Aug 30, 2020

Good idea @Alhadis. Simplecov is as good as anything else. I'll add it to my todo list.

@lildude lildude merged commit e1857e2 into github-linguist:master Aug 30, 2020
sambacha pushed a commit to freight-trust/linguist that referenced this pull request Sep 4, 2020
Alhadis added a commit to file-icons/atom that referenced this pull request Sep 17, 2020
Added:
* CoffeeScript: `.coffee.md` (github-linguist/linguist#4957)
* Lex:          `lexer.x`    (github-linguist/linguist#4952)
* NGINX:        `.nginx`     (github-linguist/linguist#4965)
* Ruby:         `.simplecov` (github-linguist/linguist#4976)
exuanbo added a commit to exuanbo/file-icons-js that referenced this pull request Oct 15, 2020
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants