Exception thrown when using render_s with asciidoc

[dometto]

Example:

GitHub::Markup.render_s(:asciidoc, "Test")

Error thrown:

no implicit conversion of nil into String

The problem is that the asciidoc rendering block assumes a filename is present (which is not the case when using render_s). See here.

[kivikakk]

Nice catch! Would you be up to submitting a PR to fix this? It might be as simple as prepending filename && before the File.basename(…) call.

@mojavelinux What's a reasonable default if no filename is given? Is passing nil here OK?

[mojavelinux]

I would recommend setting outfilesuffix to .adoc and not setting docname or docfilesuffix.

So it might be something like:

if filename
  attributes['docname'] = File.basename(filename, (extname = File.extname(filename)))
  attributes['docfilesuffix'] = attributes['outfilesuffix'] = extname
else
  attributes['outfilesuffix'] = '.adoc'
end

Though, keep in mind that setting outfilesuffix is really specific to a source tree browser like GitHub and GitLab (where you navigate from source file to source file). If this library is used in another context, it may not make sense to set outfilesuffix.

[kivikakk]

If this library is used in another context, it may not make sense to set outfilesuffix.

That makes sense! So far we're assuming that is the context for markup, so I think we're clear to proceed along the suggested line.

@dometto Would you like to make the PR? If not, I'm happy to.

[dometto]

Yes, I'll submit a PR later today! Thanks for the swift reply both of you.

[kivikakk]

Thank you!

[mojavelinux]

Thank you @dometto and @kivikakk!