Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when trying to view the CSV results of a quick evaluation #1376

Closed
aeisenberg opened this issue Jun 2, 2022 · 2 comments · Fixed by #1379
Closed

Error when trying to view the CSV results of a quick evaluation #1376

aeisenberg opened this issue Jun 2, 2022 · 2 comments · Fixed by #1379
Labels
bug Something isn't working good first issue Good for newcomers VSCode

Comments

@aeisenberg
Copy link
Contributor

  1. Perform a quick evaluation anywhere
  2. After the results view opens, Click on View CSV results for this query in the history view
  3. BUG
Exception caught at top level: /Users/andrew.eisenberg/Library/Application Support/Code/User/globalStorage/github.vscode-codeql/queries/ExternalFlow.qll-utKlrrgKpMXWbhpVDQOh2/results.bqrs has no result set called #select.
                      com.semmle.cli2.bqrs.DecodeCommand.generateOutput(DecodeCommand.java:237)
                      com.semmle.cli2.bqrs.DecodeCommand.executeSubcommand(DecodeCommand.java:213)
                      com.semmle.cli2.picocli.SubcommandCommon.executeWithParent(SubcommandCommon.java:484)
                      com.semmle.cli2.execute.CliServerCommand.lambda$executeSubcommand$0(CliServerCommand.java:67)
                      com.semmle.cli2.picocli.SubcommandMaker.runMain(SubcommandMaker.java:205)
                      com.semmle.cli2.execute.CliServerCommand.executeSubcommand(CliServerCommand.java:67)
                      com.semmle.cli2.picocli.SubcommandCommon.call(SubcommandCommon.java:500)
                      com.semmle.cli2.picocli.SubcommandMaker.runMain(SubcommandMaker.java:205)
                      com.semmle.cli2.picocli.SubcommandMaker.runMain(SubcommandMaker.java:214)
                      com.semmle.cli2.CodeQL.main(CodeQL.java:98)

What's happening is that the view CSV results is expecting a #select results set, but in this case, the results set does not exist. The only results set available is some renaming of the selected quick eval text.

I can think of two possible solutions:

  1. Turn off csv results for quick eval (not great)
  2. Arbitrarily choose a single results set to view if the #select results set is not available. 99% of the time (maybe 100% of the time) this will do the right thing.
@aeisenberg aeisenberg added bug Something isn't working good first issue Good for newcomers labels Jun 2, 2022
@github-actions github-actions bot added the VSCode label Jun 2, 2022
@adityasharad
Copy link
Contributor

Can we get the correct result set name using bqrs info? I expect there to be only one result set.

@aeisenberg
Copy link
Contributor Author

If there is more than one result set, what does it mean to be "correct"? (Maybe it's the result set prefixed by #?)

If there is exactly one result set, do we even need the name of the result set? We just need to get the single set.

In the case of quick eval, I think there's only one result set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers VSCode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants