Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HTML code blocks for sharing Markdown results #1300

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Use HTML code blocks for sharing Markdown results #1300

merged 1 commit into from
Apr 20, 2022

Conversation

shati-patel
Copy link
Contributor

This is so that we can highlight code snippets using <strong> tags, which doesn't work in normal markdown code blocks 😢 (Will do the actual highlighting in a separate PR!)

See internal issue for more context.

Checklist

N/A - internal only (and only used in tests for now)

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel
Use HTML code blocks
38381ee 
This is so that we can highlight code snippets using `<strong>` tags
@shati-patel shati-patel marked this pull request as ready for review April 19, 2022 14:05
@shati-patel shati-patel requested review from a team as code owners April 19, 2022 14:05
@shati-patel shati-patel changed the title Use HTML code blocks Use HTML code blocks for sharing Markdown results Apr 19, 2022
@shati-patel
Copy link
Contributor Author

Test failure looks unrelated... Investigating 🕵🏽‍♀️

@shati-patel shati-patel marked this pull request as draft April 19, 2022 14:30
@shati-patel
Copy link
Contributor Author

Test failure looks unrelated... Investigating 🕵🏽‍♀️

Possibly an outage in the VS Code marketplace... Will try re-running the tests in a bit 🤷🏽

@shati-patel shati-patel marked this pull request as ready for review April 19, 2022 15:14
@shati-patel
Copy link
Contributor Author

How exciting. A different (also unrelated?) test failure this time 😿

robertbrignull
robertbrignull approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@robertbrignull robertbrignull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the actual code change (for once the CI is fixed)

@aeisenberg
Copy link
Contributor

Looks like the CI errors were just temporary.

@shati-patel shati-patel merged commit a74dfea into main Apr 20, 2022
@shati-patel shati-patel deleted the shati-patel/sharing-code-snippets branch April 20, 2022 09:32
@shati-patel shati-patel mentioned this pull request Apr 20, 2022
Merged
3 tasks
@Gempita88 Gempita88 mentioned this pull request Mar 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbrignull robertbrignull robertbrignull approved these changes

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shati-patel @aeisenberg @robertbrignull