Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown results: Highlight snippets with "<strong>" #1302

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Markdown results: Highlight snippets with "<strong>" #1302

merged 1 commit into from
Apr 21, 2022

Conversation

shati-patel
Copy link
Contributor

@shati-patel shati-patel commented Apr 20, 2022 •
edited
Loading

Follow-up to #1300 and #1293 🔆

This PR actually highlights the affected code snippets using HTML <strong> tags. See internal issue for more context!

Checklist

N/A - internal only 👋🏽

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@shati-patel shati-patel marked this pull request as ready for review April 20, 2022 11:42
@shati-patel shati-patel requested review from a team as code owners April 20, 2022 11:42
@shati-patel shati-patel mentioned this pull request Apr 20, 2022
Merged
3 tasks
aeisenberg
aeisenberg approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@shati-patel shati-patel merged commit e1a10fc into main Apr 21, 2022
@shati-patel shati-patel deleted the shati-patel/sharing-code-snippets branch April 21, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shati-patel @aeisenberg