This repository has been archived by the owner on Sep 1, 2022. It is now read-only.
WIP Branch protection #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Oct 11, 2018
There was a problem hiding this comment.
General checks
README.md file |
config.yml file |
|---|---|
| ✓ | ✓ |
Required fields in config.yml
title |
description |
tagline |
steps |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Steps
✓ Enable security settings
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
✓ Find the vulnerable dependency
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
✓ Update the dependency version
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
- ✓
🚫 Merge your pull request
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- 🚫 Action of type
open issuedoes not exist. - ✓
✓ Enable protected branches
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
✓ Add to the `.gitignore` file
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
- ✓
✓ Merge the pull request
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
ghost
suggested changes
Oct 11, 2018
There was a problem hiding this comment.
General checks
README.md file |
config.yml file |
|---|---|
| ✓ | ✓ |
Required fields in config.yml
title |
description |
tagline |
steps |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Steps
✓ Enable security settings
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
✓ Find the vulnerable dependency
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
✓ Update the dependency version
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
- ✓
🚫 Merge your pull request
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- 🚫 Action of type
open issuedoes not exist. - ✓
✓ Enable protected branches
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
✓ Add to the `.gitignore` file
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
- ✓
✓ Merge the pull request
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
ghost
previously requested changes
Oct 11, 2018
There was a problem hiding this comment.
General checks
README.md file |
config.yml file |
|---|---|
| ✓ | ✓ |
Required fields in config.yml
title |
description |
tagline |
steps |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Steps
✓ Enable security settings
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
✓ Find the vulnerable dependency
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
✓ Update the dependency version
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
- ✓
🚫 Merge your pull request
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- 🚫 Action of type
createIssueis missing the required properties:body. - ✓
✓ Enable protected branches
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
✓ Add to the `.gitignore` file
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
- ✓
✓ Merge the pull request
title |
description |
event |
actions |
|---|---|---|---|
| ✓ | ✓ | ✓ | ✓ |
Actions
- ✓
- ✓
- ✓
ghost
approved these changes
Oct 11, 2018
This was referenced Oct 11, 2018
|
@JasonEtco via slack, the event doesn't exist. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #85 by adding a step where the user implements branch protection.
@JasonEtco You'd mentioned that branch protection is definitely possible but I'm not sure what event to use from the webhook documentation. Could you please point me in the right direction for line 95?