Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Sample code uses outdated @action/toolkit API #17

Closed
blaxx opened this issue Jun 20, 2020 · 1 comment · Fixed by #19
Closed

Sample code uses outdated @action/toolkit API #17

blaxx opened this issue Jun 20, 2020 · 1 comment · Fixed by #19

Comments

@blaxx
Copy link

blaxx commented Jun 20, 2020

Describe the bug
Workflow action 'create-issue' fails even though, by course description, it should succeed.

To Reproduce
Steps to reproduce the behavior:

  1. Follow the course until the end of the 'Add Third Actions JavaScript Files' step
  2. Add a label to the current pull request
  3. Check your actions tab: the workflow has failed with the error message: 'github.GitHub is not a constructor'

Expected behavior
By adding a label to my pull request I expect the workflow to finish successfully.

Screenshots
Bildschirmfoto 2020-06-20 um 22 52 06
Bildschirmfoto 2020-06-20 um 22 46 02

Additional context
Seems like the way the octokit client is created in the sample code is no longer supported by @actions/toolkit v3, also see this pull request.

@mattdavis0351
Copy link
Contributor

@blaxx @zhiliangxu Thank you for your contributions to this course. I'll address this issue, and the associate pull requests today 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants