Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to move an item top of the list and selection happens only after slight after scroll. #6

Closed
mamidala opened this issue Dec 1, 2016 · 4 comments

Comments

@mamidala
Copy link

mamidala commented Dec 1, 2016

Hi,
In iOS it is observed that an list item can be placed to bottom of the list, when we bring an item to bottom list scroll till the we get the bottom item then we can place the dragged item.
It is not happening if we want to move an item top of the list, once we drag the item to top the list wont scroll so we wont be able to move the item to top of the list.
And the other issue is like item selection wont happen immediately, it takes slight time after the scroll has stopped.

Your sortable list looks awesome.Greatly appreciated.

Thanks,
Mahender

@gitim
Copy link
Owner

gitim commented Dec 5, 2016

Hi, @mamidala!

It is not happening if we want to move an item top of the list, once we drag the item to top the list wont scroll so we wont be able to move the item to top of the list.

Maybe I don't understand you, but autoscroll is working in the example in both direction.

-05-2016 12-26-24

Could you share your example?

And the other issue is like item selection wont happen immediately, it takes slight time after the scroll has stopped.

yes, the scroll must stop before dragging, and there is small delay for long press (https://github.com/gitim/react-native-sortable-list/blob/master/src/Row.js#L5), but it doesn't look like an issue for ux.

@mamidala
Copy link
Author

mamidala commented Dec 6, 2016

Please find my explanation below.
e.g There are 15 items in the list. and currently items 10-16 visible in the list view.
when i try to move the item no.13 top of the list am not able to move to top of the list above item no.1.
Am able to to place above item no.10 but am not able to move the item to till item no.1 which is at top.
Hope this helps you to understand.
Thanks,
Mahender

@drewvolz
Copy link
Contributor

drewvolz commented Dec 9, 2016

I am witnessing this behavior as well on an iOS device... wonder what is going on with AutoScroll.

@gitim
Copy link
Owner

gitim commented Dec 10, 2016

Now I see, thanks for your feedback! Fixed in 46d4964

@gitim gitim closed this as completed Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants