Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashes (#) are percent encoded in custom remote urls #1448

Closed
tbaud0n opened this issue Mar 29, 2021 · 4 comments
Closed

Hashes (#) are percent encoded in custom remote urls #1448

tbaud0n opened this issue Mar 29, 2021 · 4 comments
Assignees
Labels
bug Something isn't working verified ✔ Verified
Milestone

Comments

@tbaud0n
Copy link

tbaud0n commented Mar 29, 2021

  • GitLens Version: 11.3.0
  • Git Version: 2.17.1
  • VSCode Version: 1.54.3
  • OS Version: Ubuntu 18.04

Configured remotes urls containings hashtag or percent symbols are entirely escaped when clicking on "Open file on remote".

Steps to Reproduce:

1.Set a custom URL in gitlens.remotes.urls config containing a hashtag or percent (ex: "fileInCommit": "http://privateRepo.com/projects/repos/${repoPath}/commits/${id}#${file}",)
2. Click on a "Open file on remote" link using this custom URL.
3. The browser open the required URL but the hashtag is escaped (ex: http://privateRepo.com/projects/repos/my-repor/commits/e62a0533fed7141beb9edfeed8dfccdd914ebae3%2523src/service/documents/downloader.go)

@tbaud0n tbaud0n added potential-bug triage Needs to be looked at labels Mar 29, 2021
@rdnlsmith
Copy link

This might be the same as #796.

@eamodio eamodio changed the title hashtag and percent escaped in gitlens.remotes urls # is percent escaped in gitlens.remotes urls Apr 6, 2021
@eamodio eamodio added bug Something isn't working and removed potential-bug triage Needs to be looked at labels Apr 6, 2021
@eamodio eamodio self-assigned this Apr 6, 2021
@eamodio eamodio added this to the Soon™ milestone Apr 6, 2021
@eamodio eamodio changed the title # is percent escaped in gitlens.remotes urls hashes (#) are percent escaped in custom remote urls Apr 6, 2021
@eamodio eamodio changed the title hashes (#) are percent escaped in custom remote urls Hashes (#) are percent encoded in custom remote urls Apr 6, 2021
@eamodio eamodio closed this as completed in 9708ae1 Apr 6, 2021
@eamodio eamodio added needs-verification Request for verification pending-release Resolved but not yet released to the stable edition labels Apr 6, 2021
@eamodio
Copy link
Member

eamodio commented Apr 6, 2021

Can you please verify this fix in tomorrow's insiders edition?

You can install the insiders edition from here. Be sure to disable/uninstall the stable version of GitLens first.

@tbaud0n
Copy link
Author

tbaud0n commented Apr 8, 2021

Thank you @eamodio, it works perfectly!

@eamodio eamodio added verified ✔ Verified and removed needs-verification Request for verification pending-release Resolved but not yet released to the stable edition labels Apr 8, 2021
@eamodio eamodio modified the milestones: Soon™, Shipped Apr 9, 2021
@github-actions
Copy link

github-actions bot commented May 9, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working verified ✔ Verified
Projects
None yet
Development

No branches or pull requests

3 participants