Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLens does not start for interractive rebase when VSCode started from command prompt #1526

Closed
n1l opened this issue May 27, 2021 · 5 comments
Labels
bug Something isn't working needs-more-info Needs further information, steps, details, etc.

Comments

@n1l
Copy link

n1l commented May 27, 2021

Hi, please help, probably something changed in vs code so that git lens does not start when vscode runs by git from command prompt.
ex:

git rebase -i master, vs code is started

image

git rebase -i master, vs code is not started

image

I tried to start debug, but nothing was in console.

my config file

[alias]
    st = status
    lol = log --stat --graph --decorate
    fap = fetch --all --prune
    please = push --force-with-lease
    co = checkout
    ci = commit
[difftool "code"]
    cmd = code  $LOCAL $REMOTE --diff -rw
[mergetool "code"]
    cmd = code $MERGED -rw
    keepBackup = false
[merge]
    tool = code
[diff]
    tool = code
[core]
    editor = code -rw
[commit]
    verbose = 2
[mergetool]
    keepBackup = false

settings.json

{
    "gitlens.advanced.messages": {
        "suppressCommitHasNoPreviousCommitWarning": false,
        "suppressCommitNotFoundWarning": false,
        "suppressFileNotUnderSourceControlWarning": false,
        "suppressGitVersionWarning": false,
        "suppressLineUncommittedWarning": false,
        "suppressNoRepositoryWarning": false
    },
    "gitlens.keymap": "alternate",
    "editor.codeLens": false,
    "editor.renderWhitespace": "all",
    "editor.tabSize": 4,
    "editor.insertSpaces": true,
    "editor.detectIndentation": false,
    "debug.allowBreakpointsEverywhere": true,
    "workbench.colorTheme": "Plastic - deprioritised punctuation",
    "window.zoomLevel": 1,
    "terminal.integrated.tabs.enabled": true
}
  • GitLens Version: v11.4.1
  • Git Version: 2.30.0.windows.2
  • VSCode Version:
    Version: 1.56.2 (user setup)
    Commit: 054a9295330880ed74ceaedda236253b4f39a335
    Date: 2021-05-12T17:13:13.157Z
    Electron: 12.0.4
    Chrome: 89.0.4389.114
    Node.js: 14.16.0
    V8: 8.9.255.24-electron.0
    OS: Windows_NT x64 10.0.19043
@n1l n1l added potential-bug triage Needs to be looked at labels May 27, 2021
@travisgroth
Copy link

I also started seeing this issue recently. I'm not seeing any difference with vscode already running vs not. Any git rebase command from the command line now gives me the old editor view instead of the gitlens view.

GitLens version: v11.4.1
git version: 2.30.1
VSCode Version: 1.56.2 054a9295330880ed74ceaedda236253b4f39a335 x64

@eamodio
Copy link
Member

eamodio commented Jun 15, 2021

Can you try to see if the issue is still reproducible in GitLens 11.5.1?

@eamodio eamodio added needs-more-info Needs further information, steps, details, etc. and removed triage Needs to be looked at labels Jun 15, 2021
@n1l
Copy link
Author

n1l commented Jun 15, 2021

@eamodio not for me for now, but there was a message from VSCode with a general security question "Do you trust this ...".

I think that this is a root cause.

https://code.visualstudio.com/docs/editor/workspace-trust

@travisgroth
Copy link

@eamodio I can't reproduce anymore on 11.5.1. I think this is fixed. Thanks!

@eamodio eamodio closed this as completed Jun 16, 2021
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2021
@eamodio eamodio added bug Something isn't working and removed potential-bug labels Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needs-more-info Needs further information, steps, details, etc.
Projects
None yet
Development

No branches or pull requests

3 participants