Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback Issue: Gitpod Public API (and Access Tokens) #15433

Open
loujaybee opened this issue Dec 20, 2022 · 8 comments
Open

Feedback Issue: Gitpod Public API (and Access Tokens) #15433

loujaybee opened this issue Dec 20, 2022 · 8 comments
Labels
feedback-issue meta: never-stale This issue can never become stale

Comments

@loujaybee loujaybee pinned this issue Dec 20, 2022
@loujaybee loujaybee changed the title Feedback Issue: Gitpod Public API Feedback Issue: Gitpod Public API (and Access Tokens) Dec 20, 2022
@mbrevoort
Copy link
Contributor

mbrevoort commented Dec 20, 2022

Some feedback annoted:
Screenshot 2022-12-20 at 8 51 41 AM

It is useless to offer an API token with "no access". We shouldn't allow it. Consider providing an identity scope and basic API method to return information about the identity of the token including the tokens ID and name and scopes. Because once you copy it, there isn't another way to correlate the token you have back to the list of tokens in the UI. If I had 10 tokens and one was compromised, but all I had was the value, how do I know which one to invalidate?

If we are going to have names for tokens, we shouldn't allow duplicates.
image

@mbrevoort
Copy link
Contributor

Additional annotated comments:
Screenshot 2022-12-20 at 9 12 01 AM

@mbrevoort
Copy link
Contributor

This seems daftly redundant. How many times do we need to say "access token"? 🤪
Screenshot 2022-12-20 at 9 16 53 AM

@mbrevoort
Copy link
Contributor

The empty state is an opportunity to educate users about the API so don't waste the space. What can I do with the API? Why would I want to? Why would I want to create an access token? If I'm less savvy and don't know what access tokens are, how do I learn?
image

@ghuntley
Copy link
Contributor

ghuntley commented Dec 28, 2022

As a general rule of thumb: the design of tokens should be matchable via Regex expression and include a checksum that external parties can use to validate offline that the token was issued by Gitpod.

@Siddhant-K-code
Copy link
Member

@ghuntley As a general rule of thumb: the design of tokens should be matchable via Regex expression and include a checksum that external parties can use to validate offline that the token was issued by Gitpod.

Yeah, our API PAT Tokens contain gitpod_pat_ as a starting slug. They can match this pattern for any token validation.

@stale
Copy link

stale bot commented May 9, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label May 9, 2023
@axonasif axonasif removed the meta: stale This issue/PR is stale and will be closed soon label May 9, 2023
@loujaybee loujaybee unpinned this issue Jul 3, 2023
@stale
Copy link

stale bot commented Sep 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Sep 16, 2023
@Siddhant-K-code Siddhant-K-code added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback-issue meta: never-stale This issue can never become stale
Projects
None yet
Development

No branches or pull requests

5 participants