From 2496bc287d7c37013feaf21c9f7e759082ac7b9c Mon Sep 17 00:00:00 2001 From: Tarun Pothulapati Date: Fri, 4 Feb 2022 09:25:06 +0000 Subject: [PATCH] gitpod: bump `node-fetch` version in extensions Related to https://github.com/gitpod-io/gitpod/issues/7360 Currently, When the server has a root cert cross-signed by the expired `DST ROOT CA X3`. There's a possiblity of the client having an older version of `electron` in their code that causes the cert expiry failure. While, asking users to update their vs code should be our first suggestion, In some cases using the latest version of `node-fetch` also fixed the issue (not exactly sure why). This PR bumps the `node-fetch` dependency to the one that the `code-server` uses. Signed-off-by: Tarun Pothulapati --- extensions/gitpod-web/package.json | 2 +- extensions/gitpod/package.json | 4 ++-- extensions/yarn.lock | 7 +++++++ 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/extensions/gitpod-web/package.json b/extensions/gitpod-web/package.json index fa769ddd6da3b..8aa1aff937a10 100644 --- a/extensions/gitpod-web/package.json +++ b/extensions/gitpod-web/package.json @@ -500,7 +500,7 @@ }, "dependencies": { "gitpod-shared": "0.0.1", - "node-fetch": "^2.6.5", + "node-fetch": "2.6.7", "uuid": "8.1.0", "vscode-jsonrpc": "^5.0.1", "vscode-nls": "^5.0.0", diff --git a/extensions/gitpod/package.json b/extensions/gitpod/package.json index 534abef12538d..02c2127b7ac07 100644 --- a/extensions/gitpod/package.json +++ b/extensions/gitpod/package.json @@ -3,7 +3,7 @@ "displayName": "%displayName%", "description": "%description%", "publisher": "gitpod", - "version": "0.0.28", + "version": "0.0.29", "license": "MIT", "preview": true, "icon": "resources/gitpod.png", @@ -45,7 +45,7 @@ "dependencies": { "@gitpod/local-app-api-grpcweb": "main", "@improbable-eng/grpc-web-node-http-transport": "^0.14.0", - "node-fetch": "^2.6.1", + "node-fetch": "2.6.7", "tmp": "^0.2.1", "vscode-nls": "^5.0.0" }, diff --git a/extensions/yarn.lock b/extensions/yarn.lock index 26c412c8baa03..2bd7b3bf2f351 100644 --- a/extensions/yarn.lock +++ b/extensions/yarn.lock @@ -680,6 +680,13 @@ ms@^2.0.0: resolved "https://registry.yarnpkg.com/ms/-/ms-2.1.3.tgz#574c8138ce1d2b5861f0b44579dbadd60c6615b2" integrity sha512-6FlzubTLZG3J2a/NVCAleEhjzq5oxgHyaCU9yYXvcLsvoVaHJq/s5xXI6/XXP6tz7R9xAOtHnSO/tXtF3WRTlA== +node-fetch@2.6.7: + version "2.6.7" + resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.7.tgz#24de9fba827e3b4ae44dc8b20256a379160052ad" + integrity sha512-ZjMPFEfVx5j+y2yF35Kzx5sF7kDzxuDj6ziH4FFbOp87zKDZNx8yExJIb05OGF4Nlt9IHFIMBkRl41VdvcNdbQ== + dependencies: + whatwg-url "^5.0.0" + node-addon-api@^3.2.1: version "3.2.1" resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-3.2.1.tgz#81325e0a2117789c0128dab65e7e38f07ceba161"