From f498a6bb937de0cb294898e96fac006a66dc2149 Mon Sep 17 00:00:00 2001 From: Tarun Pothulapati Date: Fri, 4 Feb 2022 09:25:06 +0000 Subject: [PATCH] gitpod: bump `node-fetch` version in extensions Related to https://github.com/gitpod-io/gitpod/issues/7360 Currently, When the server has a root cert cross-signed by the expired `DST ROOT CA X3`. There's a possiblity of the client having an older version of `electron` in their code that causes the cert expiry failure. While, asking users to update their vs code should be our first suggestion, In some cases using the latest version of `node-fetch` also fixed the issue (not exactly sure why). This PR bumps the `node-fetch` dependency to the one that the `code-server` uses. Signed-off-by: Tarun Pothulapati --- extensions/gitpod/package.json | 2 +- extensions/yarn.lock | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/extensions/gitpod/package.json b/extensions/gitpod/package.json index efe84ec4f88cec..19fa7bf6125219 100644 --- a/extensions/gitpod/package.json +++ b/extensions/gitpod/package.json @@ -45,7 +45,7 @@ "dependencies": { "@gitpod/local-app-api-grpcweb": "main", "@improbable-eng/grpc-web-node-http-transport": "^0.14.0", - "node-fetch": "^2.6.1", + "node-fetch": "^2.6.7", "tmp": "^0.2.1", "vscode-nls": "^5.0.0" }, diff --git a/extensions/yarn.lock b/extensions/yarn.lock index be4037e3098275..6e9aac620f25fd 100644 --- a/extensions/yarn.lock +++ b/extensions/yarn.lock @@ -672,13 +672,6 @@ ms@^2.0.0: resolved "https://registry.yarnpkg.com/ms/-/ms-2.1.3.tgz#574c8138ce1d2b5861f0b44579dbadd60c6615b2" integrity sha512-6FlzubTLZG3J2a/NVCAleEhjzq5oxgHyaCU9yYXvcLsvoVaHJq/s5xXI6/XXP6tz7R9xAOtHnSO/tXtF3WRTlA== -node-fetch@^2.6.1: - version "2.6.6" - resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.6.tgz#1751a7c01834e8e1697758732e9efb6eeadfaf89" - integrity sha512-Z8/6vRlTUChSdIgMa51jxQ4lrw/Jy5SOW10ObaA47/RElsAN2c5Pn8bTgFGWn/ibwzXTE8qwr1Yzx28vsecXEA== - dependencies: - whatwg-url "^5.0.0" - node-fetch@^2.6.5: version "2.6.5" resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.5.tgz#42735537d7f080a7e5f78b6c549b7146be1742fd" @@ -686,6 +679,13 @@ node-fetch@^2.6.5: dependencies: whatwg-url "^5.0.0" +node-fetch@^2.6.7: + version "2.6.7" + resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.7.tgz#24de9fba827e3b4ae44dc8b20256a379160052ad" + integrity sha512-ZjMPFEfVx5j+y2yF35Kzx5sF7kDzxuDj6ziH4FFbOp87zKDZNx8yExJIb05OGF4Nlt9IHFIMBkRl41VdvcNdbQ== + dependencies: + whatwg-url "^5.0.0" + node-gyp-build@^4.2.0: version "4.3.0" resolved "https://registry.yarnpkg.com/node-gyp-build/-/node-gyp-build-4.3.0.tgz#9f256b03e5826150be39c764bf51e993946d71a3"