Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A human-readable "name" for every User #377

Closed
mattyg opened this issue May 11, 2022 · 0 comments
Closed

A human-readable "name" for every User #377

mattyg opened this issue May 11, 2022 · 0 comments
Labels
discussion Issues that need more discussion and refinement before they're added to the project board refactor Improve / change the implementation of an existing feature

Comments

@mattyg
Copy link
Collaborator

mattyg commented May 11, 2022

Currently when User's are referenced in the UX, it is either by their Discord useraccount name, or their shortened ethereum address. This is determined by a utility function in the frontend.

I propose that we instead add a "name" field directly to the User model. When the associated useraccount is activated, the user name will be set to their first useraccount's name. Otherwise, the name will be set to some other value. Either a shortened version of their ethereum address, or a generated pseudonym based on their user._id.

It would also be ideal if every useraccount always had an associated user (see #361), and that user always had a standardized name, so that it could be easily referenced throughout the application.

We could then remove all the logic throughout the application which conditionally returns the UserAccount.name or shortened User.ethereumAddress depending on which data is available.

@mattyg mattyg added discussion Issues that need more discussion and refinement before they're added to the project board refactor Improve / change the implementation of an existing feature labels May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Issues that need more discussion and refinement before they're added to the project board refactor Improve / change the implementation of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants