Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node.string_content is not utf-8 #30

Closed
danielberndt opened this issue Oct 31, 2016 · 2 comments · Fixed by #31
Closed

node.string_content is not utf-8 #30

danielberndt opened this issue Oct 31, 2016 · 2 comments · Fixed by #31
Assignees

Comments

@danielberndt
Copy link

I just got a bit bitten by this one.

I was just wondering whether there's a reason for why the user of the library has to manually call node.string_content.force_encoding("utf-8") to ensure the output is actually utf-8 rather than ascii which was rather unexpected (at least to me)

Cheers :)
Daniel

@gjtorikian
Copy link
Owner

The user should not have to! I'll fix this when I've got the time (unless you want to submit a PR 😉 ).

@gjtorikian
Copy link
Owner

Release 0.13.0 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants