-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assumes files with non-utf-8 encodings are binary #22
Comments
Damn, this looks like a fun problem. I wish you hadn't opened this. 😣 The problem can be traced to this line. 16/32 BE and LE were each enough to add. The Big5, GB, and KR files have some crazy byte detection, and use the |
https://github.com/ashtuchkin/iconv-lite/blob/master/encodings/tables/big5-added.json |
Also a file with an emoji is flagged as binary.
|
It detects these files as binary:
https://github.com/benogle/encodings/blob/master/big5.txt
https://github.com/benogle/encodings/blob/master/bom_utf-16le.txt
And likely many others in https://github.com/benogle/encodings
The text was updated successfully, but these errors were encountered: