Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Triangle #69

Closed
gkjohnson opened this issue Sep 7, 2022 · 2 comments · Fixed by #104
Closed

Missing Triangle #69

gkjohnson opened this issue Sep 7, 2022 · 2 comments · Fixed by #104
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@gkjohnson
Copy link
Owner

gkjohnson commented Sep 7, 2022

In the hierarchy demo.

image

Edit:

This looks like it's a result of incorrect coplanar operation results - specifically with the "frame" component.

image

@gkjohnson gkjohnson added bug Something isn't working help wanted Extra attention is needed labels Sep 7, 2022
@gkjohnson gkjohnson added this to the v0.0.3 milestone Sep 7, 2022
@AngyDev
Copy link
Contributor

AngyDev commented Sep 16, 2022

Hi, I tried several changes, but if I set the width of the first frame from 2 to 2.1, the issue disappears.
I don't understand why, but can it be a solution?

@gkjohnson
Copy link
Owner Author

This issue is a bit trickier - adjusting the geometry itself could avoid the problem but ideally the CSG operations should never result in a mesh hole regardless of the shape. So there's something going on in the numerical robustness or something of the CSG computations. I'd like to get #68 and #51 going to help make it easier to track these issues down and fix them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants