Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a more robust "inside" detection method #74

Open
gkjohnson opened this issue Sep 12, 2022 · 0 comments
Open

Add a more robust "inside" detection method #74

gkjohnson opened this issue Sep 12, 2022 · 0 comments
Labels
help wanted Extra attention is needed
Milestone

Comments

@gkjohnson
Copy link
Owner

gkjohnson commented Sep 12, 2022

Default three.js raycasting can "leak" rays at edges where triangles meet. In order to determine whether triangles should be included or excluded in the final result we use raycasting which means we can incorrectly mark triangles as inside / outside. The solution currently is to raycast multiple times per triangle to minimize the chance. More raycasting is more performance intensive and still not immune to problems. We can implement a more robust custom triangle intersection function using bvh.shapecast to address this.

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant