Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rev bounds #12

Merged
merged 7 commits into from
Oct 16, 2018
Merged

Rev bounds #12

merged 7 commits into from
Oct 16, 2018

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 16, 2018

This PR is another module required to be updated to enable drawing the scenes with reversed bounds. In plotly.is such ranges could be set using autorange:'reversed' or range:[greater value, smaller value] .
Please refer to plotly issue and this PR.
@alexcjohnson

shaders/fragment.glsl Outdated Show resolved Hide resolved
@archmoj
Copy link
Contributor Author

archmoj commented Oct 16, 2018

Thank you for the observation @alexcjohnson
The if statement for this module is revised.

@alexcjohnson
Copy link

heh a268ac0 got one of the double-ifs, but there's another (the one I actually commented on 😈 )

@alexcjohnson
Copy link

Thanks, now you've got it! 💃

@archmoj archmoj merged commit fa52e1c into master Oct 16, 2018
@archmoj archmoj deleted the rev-bounds branch October 16, 2018 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants