Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug - other url schemes are not being rendered correctly #282

Open
kamilkosek opened this issue Dec 16, 2024 · 3 comments
Open

bug - other url schemes are not being rendered correctly #282

kamilkosek opened this issue Dec 16, 2024 · 3 comments
Labels
work completed Work for this has been completed but it may not yet be merged / released
Milestone

Comments

@kamilkosek
Copy link

What I am trying to achieve is to open VS Code Workspaces on remote machines via the bookmarks widget.

What works:

          - type: html 
            source: |
                  <a href="vscode://vscode-remote/ssh-remote+root@jellystack.kk.local/jellyplist/jellyplist.code-workspace">Worspace</a>

It is rendered like this:
image

But when adding this url to the bookmarks widget it is rendered to something different:

          - type: bookmarks
            groups:
              - title: Code Workspace´s 
                links:
                - title: Jellyplist
                  url: vscode://vscode-remote/ssh-remote+root@jellystack.kk.local/jellyplist/jellyplist.code-workspace
                  icon: https://cdn.jsdelivr.net/gh/selfhst/icons/svg/visual-studio-code.svg

image

I think it is maybe some safety feature from the rendering engine ? Don´t know, never worked with go

@svilenmarkov
Copy link
Member

svilenmarkov commented Dec 16, 2024

Hey, thanks for reporting this! You are correct in assuming that it is being incorrectly escaped by the templating engine. I'll get this fixed in the next release.

PS: that's actually a pretty cool use case, I might borrow that idea :D

@svilenmarkov svilenmarkov added this to the v0.7.0 milestone Dec 16, 2024
@svilenmarkov svilenmarkov added the work completed Work for this has been completed but it may not yet be merged / released label Dec 16, 2024
@kamilkosek
Copy link
Author

Believe me, i got so many ideas 😅
You open for PR’s with new widgets?

currently I’ve built an extension , which serves a Monaco editor to directly edit glance.yaml inside of glance and a hacky unsecure mechanism to restart the container if chnages are detected 😂

@svilenmarkov
Copy link
Member

You open for PR’s with new widgets?

Depends on what the widgets are. 😅

Next release is coming with auto reload on config change so all you'd need is an editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work completed Work for this has been completed but it may not yet be merged / released
Projects
None yet
Development

No branches or pull requests

2 participants