Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCD: calculate channel count based on metadata, not pixel bytes #255

Merged
merged 2 commits into from
Aug 7, 2024
Merged

MCD: calculate channel count based on metadata, not pixel bytes #255

merged 2 commits into from
Aug 7, 2024

Commits on Aug 6, 2024

  1. MCD: calculate channel count based on metadata, not pixel bytes 

    In some cases, the number of pixel bytes stored for a particular acquisition
may not match the expected number of bytes, so calculating the channel count
based on the stored number of pixel bytes will cause problems.

Instead of throwing an exception, this sets the channel count to the
number of channels linked to the acquisition, and logs that
some image data may be blank. This more closely matches the behavior
of MCDViewer (the vendor software).
    @melissalinkert
    melissalinkert committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    bc5ec8f View commit details
    Browse the repository at this point in the history

  2. MCD: don't allow openBytes to read beyond the end of an acquisition 

    This prevents incorrect data from being read when the number of
stored pixel bytes is smaller than expected.
    @melissalinkert
    melissalinkert committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    bd42c7c View commit details
    Browse the repository at this point in the history