Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Todo: add tests around component destruction #382

Open
NullVoxPopuli opened this issue Feb 24, 2022 · 0 comments
Open

Todo: add tests around component destruction #382

NullVoxPopuli opened this issue Feb 24, 2022 · 0 comments

Comments

@NullVoxPopuli
Copy link
Contributor

Discovered in: #379 (comment)

We found that we could migrate to @ember/destroyable in @glimmer/component's ember-component-manager without failure in ember-source < 3.22 -- this is problematic because @ember/destroyable doesn't exist in older embers -- so it means we are missing important test coverage around destruction.

PRs and help welcome <3

@NullVoxPopuli NullVoxPopuli mentioned this issue Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant