Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for form factor #93

Open
vyasr opened this issue Oct 6, 2020 · 0 comments
Open

Add tests for form factor #93

vyasr opened this issue Oct 6, 2020 · 0 comments

Comments

@vyasr
Copy link
Contributor

vyasr commented Oct 6, 2020

Feature description

It would be good to validate the form factor calculation much more thoroughly than the current implementation (either in the legacy ft.py module or in the new code in #92.

Proposed solution

There are many known form factors described here. We should use some of these as test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vyasr