Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add token or password #122

Closed
joaander opened this issue Apr 4, 2022 · 1 comment · Fixed by #158
Closed

Add token or password #122

joaander opened this issue Apr 4, 2022 · 1 comment · Fixed by #158
Labels
enhancement New feature or request
Milestone

Comments

@joaander
Copy link
Member

joaander commented Apr 4, 2022

Feature description

Require the use of token or password security by default.

Proposed solution

For example, (by default) jupyter lab creates a random token and displays it on the console.

Additional context

Without authentication, signac-dashboard instances are open to all users on a multi-user system (such as a cluster login node). Malicious users could use this connection to read your signac dashboard, write if any modules enable writing, and possibly take control of your account through vulnerabilities.

@joaander joaander added the enhancement New feature or request label Apr 4, 2022
@bdice
Copy link
Member

bdice commented Apr 4, 2022

This is a good idea and is needed to move the project from being a prototype to a production-level package. I do not have a timeline planned for adding this feature myself, but I would support any contributor who wishes to implement this. Jupyter Notebook's security page may be a helpful reference.

@cbkerr cbkerr added this to the v0.4.0 milestone Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants