Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flask's send_file parameter names have changed #142

Closed
tcmoore3 opened this issue Aug 12, 2022 · 2 comments · Fixed by #143
Closed

flask's send_file parameter names have changed #142

tcmoore3 opened this issue Aug 12, 2022 · 2 comments · Fixed by #143
Assignees
Labels
bug Something isn't working

Comments

@tcmoore3
Copy link
Member

tcmoore3 commented Aug 12, 2022

Description

As of flask version 2.2.0, the cache_timeout parameter of send_from_directory is removed. It was deprecated in favor of max_age in version 2.0.0. Hence, if using flask >= 2.2, any dashboard that uses the ImageViewer, FileList, or VideoViewer modules will not display the content of the cards as expected.

To reproduce

Run a dashboard that displays images where the flask version >= 2.2.

@tcmoore3 tcmoore3 added the bug Something isn't working label Aug 12, 2022
@tcmoore3 tcmoore3 self-assigned this Aug 12, 2022
@bdice
Copy link
Member

bdice commented Aug 12, 2022

Thanks! If you can contribute a PR to fix this and bump the requirements to flask>=2, that'd be great.

@tcmoore3 tcmoore3 mentioned this issue Aug 12, 2022
5 tasks
@tcmoore3
Copy link
Member Author

Thanks! If you can contribute a PR to fix this and bump the requirements to flask>=2, that'd be great.

Already on it!

@cbkerr cbkerr mentioned this issue Oct 17, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants