Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fill no longer works in scatter plot marker #382

Closed
pllim opened this issue Aug 11, 2023 · 1 comment · Fixed by #384
Closed

fill no longer works in scatter plot marker #382

pllim opened this issue Aug 11, 2023 · 1 comment · Fixed by #384
Labels
bug Something isn't working

Comments

@pllim
Copy link
Contributor

pllim commented Aug 11, 2023

Describe the bug

I think #363 by @astrofrog broke the fill=False functionality in scatter plot markers. I used to be able to draw unfilled circle but no longer is the case.

To Reproduce

Run the W5 example notebook in this repo. In the scatter viewer, untoggle "fill markers" switch. Markers remain solid.

Expected behavior

Markers should be unfilled.

Screenshots

Screenshot 2023-08-11 171824

Additional context

The markers behavior changed in Jdaviz when I use dev version of glue-jupyter.

🐱

@pllim
Copy link
Contributor Author

pllim commented Aug 19, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant