Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please test downstream packages before releasing #2383

Closed
pllim opened this issue Apr 10, 2023 · 1 comment
Closed

Please test downstream packages before releasing #2383

pllim opened this issue Apr 10, 2023 · 1 comment

Comments

@pllim
Copy link
Contributor

pllim commented Apr 10, 2023

This is in regards to da68d1a#r107847297 (#2344) that got merged last minute before glue-core v1.9 was released. As a result, Jdaviz never had a chance to catch that it broke our stuff downstream even though we have CI job to test against glue dev stack.

Now we are unable to take advantage of another feature that was in the same release (#2379) for unit conversion work downstream.

In the future, please give downstream a chance to catch problems before a stable release.

xref glue-viz/glue-jupyter#349 and spacetelescope/jdaviz#2135

@astrofrog
Copy link
Member

I've now set up an integration testing repo to help us check whether we can go ahead with releases without breaking downstream: https://github.com/glue-viz/glue-integration-testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants