This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
Bump dependencies version #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshlm
approved these changes
Aug 3, 2018
| @@ -39,5 +39,27 @@ install_gometalinter() { | |||
| rm -f "$GOBINDIR/$LINTER_TARBALL" | |||
| } | |||
|
|
|||
| install_etcd() { | |||
There was a problem hiding this comment.
I"m not sure if it was present as elastic etcd was the default.
|
retest this please |
1 similar comment
|
retest this please |
...as we were using a really old version Signed-off-by: Prashanth Pai <ppai@redhat.com>
We specifically need fixes related to auto compaction of etcd keyspace. These fixes are in an etcd version > v3.3.3 More here: https://github.com/coreos/etcd/blob/master/Documentation/op-guide/maintenance.md Signed-off-by: Prashanth Pai <ppai@redhat.com>
The latest golang version is 1.10.3. We are bumping golang version to the previous stable version that is present as a package in base repo on centos 7. Signed-off-by: Prashanth Pai <ppai@redhat.com>
prashanthpai
force-pushed
the
bump-dependencies-version
branch
from
549a13d
to
4252dfc
Compare
rishubhjain
added a commit
to rishubhjain/glusterd2
that referenced
this pull request
Aug 8, 2018
With respect to gluster#1123. Using golang 1.9 or higher instead of 1.8. @prashanthpai Please check if we need to make changes in any other documentation.
kshlm
pushed a commit
that referenced
this pull request
Aug 8, 2018
With respect to #1123. Using golang 1.9 or higher instead of 1.8. @prashanthpai Please check if we need to make changes in any other documentation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Centos 7 is 1.9.4, latest stable release is 1.9.7
We specifically need fixes related to auto compaction of etcd keyspace.
These fixes are in an etcd version >= 3.3.3. Centos7 is still on 3.2.22 though.