Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Songs are blocked when they shouldn't be #32

Closed
xdmx opened this issue Dec 26, 2014 · 2 comments
Closed

Songs are blocked when they shouldn't be #32

xdmx opened this issue Dec 26, 2014 · 2 comments

Comments

@xdmx
Copy link

xdmx commented Dec 26, 2014

I open a new issue to keep it separate from the solved one

So, I have tried with the default settings and it happens as well, these are the steps i did:

  • temporally renamed the config, playlist and blocklist in order to use the default settings
  • open the spotify window
  • start a song
  • quickly click on the next song button

You'll see in the blockify (CLI) log that sometimes it blocks some songs, even if the blocklist is empty

This is a quick way I've found to replicate it, the same problem happens also without skipping songs, but just when you listen to spotify normally. Sometimes I see that it blocked a song, and started the interlude when it shouldn't have, I don't know how to replicate this, it appears to be quite random

@gmdfalk
Copy link
Owner

gmdfalk commented Dec 26, 2014

I think i see what you mean. It sometimes mutes a song for a fraction of a second because title information isn't updated quickly enough. This becomes a problem when autoresume is turned off as the interlude starts playing and will only stop when it finished, as its supposed to. Meanwhile the now unmuted song is paused.

I'm testing a fix right now.

@gmdfalk
Copy link
Owner

gmdfalk commented Dec 26, 2014

This is indeed a tricky issue. The problem is that Spotify has an internal delay when updating window title information which blockify relies on. The only way i see around this right now is to, in turn, delay the decision whether to play interlude music by about the same time.
I have introduced a new "playback_delay" option in the interlude section and set it to a very safe value of 750ms. Feel free to play with this setting.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants