-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move _filetest.gno to filetests/* folder. #846
Comments
@harry-hov whats the current state, did you start? I think it could be a good task for @gfanton yo complete his onboarding on the VM + CLI parts of the project. |
it doesn't looks too complicated at first glance, I can try to do this, but maybe @harry-hov already have something |
I've initiated a small pull request #1062. It seems to work naturally by simply adding
|
I started working on that with my another work about publishing subdirs. I followed a similar approach to what you did in your PR #1062. I cherry-picked and pushed my commit here(harry-hov@dfe2e8b) just in case if you want to take a look |
@harry-hov Is this feature truly dependent on publishing subdir? Given that filetests are not executed on-chain (yet?), can we not handle this separately? |
Not exactly. I would just like to have that feature first. But TBH. i have no preference. if your PR is ready we can go ahead with this change first (considering we are okay with not publishing filetests on chain) |
See-also: #1346 as an alternative. As a more radical approach, but I think better in the long term, I propose removing filetests for end users altogether :) |
I suggest doing the opposite by allowing them and adding support for txtar testing as well. Allowing this doesn't imply favoring them over standard unit tests. It aims to make it easier for users needing this feature to work outside the main monorepo. The goal is to allow creating a standalone repository with .gno files, _test.gno files, and a subfolder for advanced tests, catering to advanced users. cc @gfanton |
The _filetests clog the gno package directory; instead of _filetest.gno, we should move the files into a ./filetests/ folder, and remove the _filetest.gno file extension.
The text was updated successfully, but these errors were encountered: