Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chain] Move the genesis command suite to gnoland genesis #1953

Closed
zivkovicmilos opened this issue Apr 18, 2024 · 0 comments · Fixed by #1954
Closed

[chain] Move the genesis command suite to gnoland genesis #1953

zivkovicmilos opened this issue Apr 18, 2024 · 0 comments · Fixed by #1954
Assignees
@zivkovicmilos
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Milestone
🏗4️⃣ test4.gno.land

Comments

@zivkovicmilos
Copy link
Member

Description

Master issue: #1836

This issue concerns moving the genesis command suite, which is currently standalone, to be under gnoland genesis (subcommand of gnoland). The reason for this move is that the genesis command suite is a fundamental part of the gnoland binary experience.

Successful outcome of this task:

  • all functionality that was invoked with the genesis binary is now moved over to gnoland genesis
@zivkovicmilos zivkovicmilos added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Apr 18, 2024
@zivkovicmilos zivkovicmilos self-assigned this Apr 18, 2024
@zivkovicmilos zivkovicmilos mentioned this issue Apr 18, 2024
Merged
7 tasks
thehowl pushed a commit that referenced this issue Apr 19, 2024
@zivkovicmilos
refactor!: move genesis to gnoland genesis (#1954)
c628334 
## Description

Closes #1953 

This PR moves the `genesis` command suite to be a subcommand of
`gnoland`, making it callable with `gnoland genesis`.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
omarsy pushed a commit to TERITORI/gno that referenced this issue Apr 21, 2024
@zivkovicmilos @omarsy
refactor!: move genesis to gnoland genesis (gnolang#1954)
3857344 
## Description

Closes gnolang#1953 

This PR moves the `genesis` command suite to be a subcommand of
`gnoland`, making it callable with `gnoland genesis`.

<details><summary>Contributors' checklist...</summary>

- [x] Added new tests, or not needed, or not feasible
- [x] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [x] Updated the official documentation or not needed
- [x] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [x] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
@Kouteki Kouteki mentioned this issue May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zivkovicmilos zivkovicmilos

Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
🧙‍♂️gno.land core team
Status: Done
Milestone
🏗4️⃣ test4.gno.land
Development

Successfully merging a pull request may close this issue.

refactor!: move genesis to gnoland genesis zivkovicmilos/gno
1 participant
@zivkovicmilos