Crash on Terminal resize when using fish

[Benimautner]

Describe the bug
When setting the default shell to fish and then trying to resize a terminal to a very small window, Terminator will crash. This does not happen every time, but it is easily possible to reproduce.

To Reproduce

• install fish sudo apt install fish
• change default shell to fish chsh -s /usr/bin/fish
• open terminator terminator
• open two terminals above each other STG + SHIFT + O
• resize using STRG + SHIFT + ARROW UP / ARROW DOWN
  • bug seems to occur more often if arrow keys are being held down
• terminator crashes

I can provide a screen capture if one is needed.

Expected behavior
No Crash

Log
terminator -d -u -g /dev/null
https://pastebin.com/U3GQaJQB

Most important lines:

VTE:ERROR:../src/vteaccess.cc:628:void vte_terminal_accessible_text_scrolled(VteTerminal*, gint, gpointer): assertion failed: (i >= 1)
Bail out! VTE:ERROR:../src/vteaccess.cc:628:void vte_terminal_accessible_text_scrolled(VteTerminal*, gint, gpointer): assertion failed: (i >= 1)
Aborted (core dumped)

Desktop (please complete the following information):

• Ubuntu 20.04
• Linux 5.8.0
• Desktop environment: KDE

Additional context
Bug #153 seems to be related as that user was using fish too.

[mattrose]

Judging by the error message, this is an error in the VTE library that Terminator uses. I think (though I'm not 100% sure) that this is fixed in a later release. Can you try updating the vte packages to see if that fixes it?

gir1.2-vte-2.91 and libvte-2.91-0

[Benimautner]

This has fixed the issue, but I had to compile and install the newest version of vte directly from source to get it to work. Thanks for your help!