Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SaveLastSessionLayout blocks exiting #941

Open
ethsol opened this issue Aug 21, 2024 · 1 comment
Open

SaveLastSessionLayout blocks exiting #941

ethsol opened this issue Aug 21, 2024 · 1 comment

Comments

@ethsol
Copy link

ethsol commented Aug 21, 2024

Thanks for the SaveLastSessionLayout plugin by @vssdeo.

Unfortunately it interferes with closing the terminal, it hangs.

Steps to reproduce:

  1. Back up your terminator config file:
    cp -p ~/.config/terminator/config{,_$(date -I).bak}
  2. Create a config file which only contains this plugin:
    echo -e "[global_config]\n enabled_plugins = SaveLastSessionLayout" > ~/.config/terminator/config
  3. Test it to see hanging:
    start terminator
    press Shift+Ctrl-O to open a new pane.
    Now comes the bad part: press Ctrl-D to close the terminal.
    It does not close just hangs.
    Press Alt-Up to move to the upper pane.
    Press Ctrl-D to try closing this pane as well.
    It doesn't close just hangs.
    Close terminator
  4. Now let's check whether terminator works without the SaveLastSessionLayout plugin.
    Create a config file containing only a \n:
    echo > ~/.config/terminator/config
  5. See terminator working well:
    start terminator
    press Shift+Ctrl-O to open a new pane.
    press Ctrl-D to close the terminal.
    Pane closes, only one terminal remains open.
    Press Ctrl-D to close this as well.
    It works.
  6. Restore your normal terminator config file:
    cp -b ~/.config/terminator/config{_$(date -I).bak,}

So the culprit should be the SaveLastSessionLayout plugin. Can you please repair it?

Desktop (please complete the following information):

  • OS or Linux Distribution: [e.g. FreeBSD or Ubuntu] : Ubuntu 22.04.4 LTS.
  • Version [e.g. 20.04]: terminator/jammy,jammy,now 2.1.4-1
  • Display Technology: Wayland or X11: Wayland
@vssdeo
Copy link
Contributor

vssdeo commented Aug 23, 2024

Thanks @ethsol for finding the issue and giving a detailed report. Can you help me with a few details since I am not able to reproduce.

  1. run terminator with -d and attach the logs here
  2. can you enable any other plugin and see if the same bug appears
  3. if possible can you try the same on your same machine using the github master code.

meanwhile I will try again to reproduce, may be I am missing out a step or two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants