Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction guard #224

Closed
rmeissner opened this issue Jul 9, 2020 · 1 comment · Fixed by #276
Closed

Transaction guard #224

rmeissner opened this issue Jul 9, 2020 · 1 comment · Fixed by #276

Comments

@rmeissner
Copy link
Member

Add a transaction guard to can impose additional constraints for executing a transaction.

E.g. Safe configuration changes need to be announced beforehand or no delegate calls are allowed.

Open questions

  • It is easy to "brick" a Safe with a wrong guard, how can this be prevented.
@rmeissner rmeissner added the future Features for next major contract version label Jul 9, 2020
@CJentzsch
Copy link

I am very much in favor of this. With this one could for example, always require a certain key to be part of the signatures when the value to be sent is above a certain limit.

Regarding the security risks. They are at the same level as a wrong/malicious module.
A module could allow anyone to bypass the threshold rule and drain the wallet. A guard could also destroy the wallet completely by preventing access forever. The wallet is as secure as its weakest module/guard.

@rmeissner rmeissner added this to the contracts-safe-1.3.0 milestone Jan 18, 2021
rmeissner added a commit that referenced this issue Mar 17, 2021
@rmeissner rmeissner removed the future Features for next major contract version label Mar 19, 2021
Uxio0 pushed a commit that referenced this issue May 6, 2021
Saw-mon-and-Natalie pushed a commit to Saw-mon-and-Natalie/safe-contracts that referenced this issue Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants