Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Reverse ENS lookup #3231

Closed
katspaugh opened this issue Jan 3, 2022 · 3 comments · Fixed by safe-global/safe-core-sdk#136 or #3262
Closed

Reverse ENS lookup #3231

katspaugh opened this issue Jan 3, 2022 · 3 comments · Fixed by safe-global/safe-core-sdk#136 or #3262
Assignees
Labels
Enhancement ✨ Minor Improvement / changes to existing functionality
Milestone

Comments

@katspaugh
Copy link
Member

katspaugh commented Jan 3, 2022

Overview

Many dapps show your ENS name when connecting a wallet. Safe could benefit from this as well, to more easily identify Safes and contacts.

Goals

  • Make it easier to find the right Safe, owner, contact etc
  • Help validated inputted addresses by displaying a human-readable name
  • Reduce the reliance on the locally stored address book

Requirements

  • Add a function to lookup an ENS domain from the address hash
  • Display the ENS Name as a default owner name when adding or creating a safe
  • Chop off the .eth to not bind ourselves with possible ENS record updates

Screens

Safe creation
Screenshot 2022-01-05 at 16 52 16

@katspaugh katspaugh added the Enhancement ✨ Minor Improvement / changes to existing functionality label Jan 3, 2022
@rmeissner
Copy link
Member

rmeissner commented Jan 3, 2022

Do we have a related issue for mobile? This is something that our clients should probably align on.

We discussed this in the past too, probably makes sense to revisit the discussions from that point: https://docs.google.com/document/d/1UTqBIpyHlWVFk-iY3uQ4dDcu-gvSigki0FOilJCD_r0/edit

Edit:

  • How do we handle unicode characters?
  • Do we want to handle edge cases that might cause confusion (e.g. for an address input - you input an ens address and the reverse ens address is different)

@katspaugh
Copy link
Member Author

katspaugh commented Jan 6, 2022

@rmeissner so far we simply added a method in the Core SDK.

Given the nuances discussed in the doc you linked, we'd like to use it in one single place in the UI:

  • as a placeholder for owner names in Safe creation/adding

This is unobtrusive and shouldn't break anything. Users will still be able to enter a custom name for each owner.

@rmeissner
Copy link
Member

Looking at the screenshot I would probably remove the tld :D (e.g. franco for franco.eth)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement ✨ Minor Improvement / changes to existing functionality
Projects
None yet
3 participants