You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the suffix X96 is meaningful because it tells us the bigint is actually a 96-bit fixed point integers, but I agree that they should not appear in the variable names. A better way would be defining a new X96 wrapper type so we can enforce the decimal computation at the type level. Once we adapt u256 types we can also work on it.
if swap only uses Q96 notation, I do agree making wrapper might be better
BUT, if my memory serves me right swap uses not only x96, but x128 too.
After we finish all of refactor stuff, if swap uses only few(I think up to two) Qx notations we can make wrapper, larger than that.... it might be to lead us too many wrapper being exist
I think the suffix
X96
is meaningful because it tells us the bigint is actually a 96-bit fixed point integers, but I agree that they should not appear in the variable names. A better way would be defining a new X96 wrapper type so we can enforce the decimal computation at the type level. Once we adapt u256 types we can also work on it.Originally posted by @mconcat in #160 (comment)
The text was updated successfully, but these errors were encountered: