-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminix crashs when changing profile settings #17
Comments
Thanks for the report, based on your other report I assume you are using Fedora? What version are you using? |
I'm using Fedora 23 with Gnome 3.18.3 |
Is this reproducible and was there a specific setting you were changing? If it's reproducible, does it run better if you run it as follows: G_SLICE=always-malloc terminix I'm not having any luck with reproducing it in my Fedora VM, though I did discover a couple of other issues. |
Yes i still can reproduce it, all i have is to play with profiles settings
|
This line in particular:
was causing a crash in Ubuntu and has been fixed, can you try the 0.35 version I just uploaded. Note there is a new issue with this version where if you set the encoding it fails so avoid changing that, but everything else in profiles will hopefully work. |
Thanks for the quick fix & answers! i will try this tomorrow. |
I spoke too soon, I am able to reproduce this in Oracle Linux 7.2. I'll investigate. |
Note this is fixed with a local patch to GtkD, GtkD should be updated shortly. Until it is, any builds done from scratch will still have this issue. See GtkD discussion on this issue here: |
Thanks 👍 |
Hmm, turns out this is partially fixed, If you have the option "Use system colors as foreground and background" set you get the same problem. It is the same bug in GtkD, will fix it later today. Also, this problem looks like it it may be in a few spots in GtkD, basically anywhere there is an out parameter that returns a class. Having said that, these color related ones really highlight the issue because just moving the transparency slider back and forth causes a large number of these calls to be made. Will need a more comprehensive fix from GtkD. |
Pushed the fix for the other memory issue in the profile dialog in 0.36.1. However, since doing this right relies on a fix from GtkD I'm going to leave this issue open until then. I would appreciate some feedback from folks who had the crash issue if things are more stable now or if they still experience issues. |
Should be fixed now with the new version of GtkD. If memory crash issues persist please open a new issue. |
The text was updated successfully, but these errors were encountered: