-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quake mode switch disables app menu/icon under GNOME 3.20 #471
Comments
I checked in some new code about an hour ago, can you check that out and see if it fixes the issue as it seems fine to me. Still have a focus issue to work on though. |
I spoke too soon, I can replicate this under Wayland. No clue as to what the solution is though, It will need more investigation. Might also be a bug with gnome-shell. |
Filed an upstream bug for this: |
So upstream responded, doesn't look the two methods I'm using in x11 to hide from the pager and taskbar work in Wayland. The other issue is there may be a bug in Wayland with the appmenu when a window is hidden and shown, if the hide from taskbar worked you would never see the appmenu in Wayland so it would be a non-issue. I'll build a simple reproducer for the hide/show and open a new bug against gnome-shell if I can reproduce it, |
I notice lollypop has issues as well with the appmenu under Wayland when you set the option for continuous playback where the app keeps running. |
One more upstream bug filed: |
Yes, that's always been the intent as nothing in the application menu is very useful since the quake window is an always-on-top window. Opening things like Preferences and Shortcuts makes them appear under the quake'ed terminix window. I'm open to having a discussion about it though. Unfortunately Wayland doesn't respect the taskbar and pager hints which is the only reason it shows up there. |
Oh, I didn't know that because I used it for the first time under Wayland. 😄 I don't have issue with that really, but it was only an observation. |
No worries, I'll freely admit I'm not a user of drop down terminals so the way features are presented may not be aligned with users expectations, hence why I'm happy to have a discussion about it. Anyway, I'm going to close this issue since under Wayland it appears to be an upstream issue since I can reproduce it with three different applications (Terminix, Geary and Lollypop). |
I'm using Fedora 24 + GNOME 3.20 + Wayland. I assigned a hotkey for
terminx --quake
and it worked for the first time amazingly.Then when I switched back to it (toggled the window visibility using the hotkey), the app menu (in GNOME Shell top bar) has become one option (Quit) and the app name became "terminix" (starting with small letter) with a generic app icon!
Before switching the visibility:
After switching the visibility:
The text was updated successfully, but these errors were encountered: