Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge context package with the main package #96

Closed
sagikazarmark opened this issue May 10, 2020 · 1 comment · Fixed by #104
Closed

Merge context package with the main package #96

sagikazarmark opened this issue May 10, 2020 · 1 comment · Fixed by #104
Labels

Comments

@sagikazarmark
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Currently the stdlib context and gobdd context packages can only be used in one file together with import aliases.

Describe the solution you'd like
Merge the context package with the main package. The functionality belongs closely together anyway.

Describe alternatives you've considered
Create an interface in the main package (interfaces belong to consumers).

Related #83

Additional context
This could be a backwards compatible change: we could keep the original package and add a type alias pointing to the new type in the root package.

@sagikazarmark sagikazarmark added enhancement New feature or request proposal labels May 10, 2020
@bkielbasa
Copy link
Collaborator

the context was moved to his own package because I had problems with testhttp package. Go doesn't permit import cycles. We removed the testhttp package from the main repository so IMO we can go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants