-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge context package into the main package #104
Conversation
thanks for your contribution! I think we can remove the context package in v2.0. IMO we can make |
Oh, it looks like we cannot make |
please fix linter issues and I can merge it |
One of the failing lint rules seems to be false positive. |
c1283fa
to
0fac6be
Compare
0fac6be
to
3ee0647
Compare
I think this is false positive. I can either disable linting in this line with |
@sagikazarmark let's disable it for this line for now. If we'll have more problems like that we can disable it entirely. |
3b4e79d
to
d20c4cc
Compare
@sagikazarmark you don't have to rebase commits because I squash and merge them anyway :) |
Thanks for your contribution! |
Fixes #96
This is a fully backwards compatible change by adding aliases for the necessary type (Context).
ToDos
NewContext
does not have to be exported. Should it be?Possible alternatives