Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: run rules #152

Merged
merged 1 commit into from
May 6, 2024
Merged

feat: run rules #152

merged 1 commit into from
May 6, 2024

Conversation

vlalanne
Copy link
Contributor

@vlalanne vlalanne commented May 3, 2024

New keyword introduced in gherkin 6: https://cucumber.io/docs/gherkin/reference/#rule

Feature: math operations
  Rule: add things
    Scenario: add two digits
      When I add 1 and 2
      Then the result should equal 3

bkielbasa
bkielbasa reviewed May 6, 2024
View reviewed changes
Copy link
Collaborator

@bkielbasa bkielbasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd rename the function I commented and we should be good. Thanks for the PR, BTW! Looks awesome :)

gobdd.go Outdated Show resolved Hide resolved
@bkielbasa
Copy link
Collaborator

thanks for your contribution!

@bkielbasa bkielbasa merged commit f6e40b3 into go-bdd:master May 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkielbasa bkielbasa bkielbasa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vlalanne @bkielbasa