Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoCache middlewares should not remove preconditions from request #801

Open
pboguslawski opened this issue Mar 3, 2023 · 2 comments
Open

Comments

@pboguslawski
Copy link

NoCache middleware removes preconditions from request but describes itself as cache disabling middleware. According to https://www.rfc-editor.org/rfc/rfc7232 preconditions may be used for protection against lost updates even when no caching is enabled for resource.

NoCache middleware should touch only response headers not request headers probably and should not block headers required for conditional requests to work.

@VojtechVitek
Copy link
Contributor

Hi @pboguslawski,

It looks like you have closed #804 PR. Is this issue still valid?

NoCache middleware should touch only response headers not request headers probably and should not block headers required for conditional requests to work.

Can you please elaborate on the word probably? I'm reading this issue for the first time without having dived into RFC-7232 in detail and I'm trying to understand if there are any action items.

Thanks

@pboguslawski
Copy link
Author

pboguslawski commented Sep 19, 2024

It looks like you have closed #804 PR. Is this issue still valid?

No I didn't. Not my PR.

Can you please elaborate on the word probably?

probably = not sure = should be verified by this middleware autor (why it was designed like this)

I'm trying to understand if there are any action items

Issue is still open and should be fixed IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants