Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ActivityPub Accept & Content-Type Header Detection #58

Closed
cjslep opened this issue Jul 28, 2018 · 1 comment
Closed

Fix ActivityPub Accept & Content-Type Header Detection #58

cjslep opened this issue Jul 28, 2018 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@cjslep
Copy link
Member

cjslep commented Jul 28, 2018

Mastodon federates by sending the Accept header as:

application/activity+json, application/ld+json

Which should match based on the alternatives laid out on the ActivityPub spec. However, it doesn't as the underlying code is not robust. The golang HTTP library doesn't have good built-in manipulation of the Accept or Content-Type (Media Type), so I will need to partially parse the BNF properly.

The previous fix in #43 was only a band-aid fix for the C2S implementation report. It is not a sufficient solution.

@cjslep cjslep added the bug Something isn't working label Jul 28, 2018
@cjslep cjslep added this to the 0.1.2 milestone Jul 28, 2018
@cjslep cjslep self-assigned this Jul 28, 2018
@cjslep
Copy link
Member Author

cjslep commented Aug 1, 2018

Fixed in b0c125a

@cjslep cjslep closed this as completed Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant