Close the dataRC reader sooner (#16023)

Fix #15932 Signed-off-by: Andrew Thornton <art27@cantab.net>
go-gitea · May 30, 2021 · 36dce0e · 36dce0e
1 parent effad26
commit 36dce0e
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/routers/repo/editor.go b/routers/repo/editor.go
@@ -106,6 +106,7 @@ func editFile(ctx *context.Context, isNewFile bool) {
 			ctx.NotFound("blob.Data", err)
 			return
 		}
+
 		defer dataRc.Close()
 
 		ctx.Data["FileSize"] = blob.Size()
@@ -122,6 +123,10 @@ func editFile(ctx *context.Context, isNewFile bool) {
 		}
 
 		d, _ := ioutil.ReadAll(dataRc)
+		if err := dataRc.Close(); err != nil {
+			log.Error("Error whilst closing blob data: %v", err)
+		}
+
 		buf = append(buf, d...)
 		if content, err := charset.ToUTF8WithErr(buf); err != nil {
 			log.Error("ToUTF8WithErr: %v", err)