Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPG signed commits incorrectly listed as invalid #10420

Closed
zeripath opened this issue Feb 22, 2020 · 1 comment · Fixed by #10735
Closed

GPG signed commits incorrectly listed as invalid #10420

zeripath opened this issue Feb 22, 2020 · 1 comment · Fixed by #10735
Labels
type/bug
Milestone
1.11.4

Comments

@zeripath
Copy link
Contributor

  • Gitea version (or commit ref): master
  • Git version:
  • Operating system: linux

Description

Go-Git incorrectly reads dates on which could be within the local timezone. An example being that a commit with date:

1579639200 +0100

Within the UK will be incorrectly parsed and re-represented as:

1579639200 +0000

A fix has been pushed to go-git as src-d/go-git#1291
@zeripath
Copy link
Contributor Author

A likely workaround would be to run your server in the UTC TZ.

@zeripath zeripath added type/bug status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR labels Feb 22, 2020
@zeripath zeripath added this to the 1.11.2 milestone Feb 22, 2020
@jolheiser jolheiser modified the milestones: 1.11.2, 1.11.3 Mar 2, 2020
@lunny lunny modified the milestones: 1.11.3, 1.11.4 Mar 10, 2020
@lafriks lafriks removed the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label Mar 16, 2020
@lafriks lafriks mentioned this issue Mar 16, 2020
Merged
@zeripath zeripath mentioned this issue Apr 7, 2020
Closed
7 tasks
@go-gitea go-gitea locked and limited conversation to collaborators Apr 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.11.4
Development

Successfully merging a pull request may close this issue.

Migrate to go-git/go-git v5.0.0 lafriks-fork/gitea
4 participants
@lunny @lafriks @zeripath @jolheiser