Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow backticks in issue titles, PR titles and commits(?) #10601

Closed
alexanderadam opened this issue Mar 4, 2020 · 10 comments
Closed

Allow backticks in issue titles, PR titles and commits(?) #10601

alexanderadam opened this issue Mar 4, 2020 · 10 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone

Comments

@alexanderadam
Copy link

alexanderadam commented Mar 4, 2020

Description

I'm not sure what's left to say but it would be great if backticks in issue titles would be supported.
According to it's maintainer, goldmark provides an "easy way" to do this.

Screenshots

Left is how it could be and right is Gitea.
Screenshot_20200304_084808

@lafriks
Copy link
Member

lafriks commented Mar 4, 2020

I don't think GitHub does support that either
image

@lafriks lafriks added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Mar 4, 2020
@alexanderadam
Copy link
Author

alexanderadam commented Mar 4, 2020

Oh, my fault! Indeed! The behaviour on GitHub came through a browser extension that I use! 😆

What do you think about it in general?

@lafriks
Copy link
Member

lafriks commented Mar 4, 2020

I have no much opinion tbh. It would require custom markdown rendering implemented to allow only backticks but no other markdown syntax and need to add that in quite some places where issue title is displayed to be consistent.

@silverwind
Copy link
Member

The question is, where would it stop? If you render issue titles with <code>, PR titles would need the same treatment, which in turn means commit descriptions would need it too for conistency.

I really think commit descriptions should be left as-is to render the same as in a terminal. I don't really like the link replacement that both gitea and GitHub do because it makes a commit description not copyable in verbatim.

@alexanderadam
Copy link
Author

If you render issue titles with <code>, PR titles would need the same treatment, which in turn means commit descriptions would need it too for conistency.

Yes, absolutely! I totally agree that all three places should have the backtick logic. I mean, people are using them anyway in commits, as they know it from other places:

Screenshot_20200304_205351

So I guess it would be a natural thing to render it like what people had in mind when they used the backticks.

@alexanderadam alexanderadam changed the title Allow backticks in issue titles Allow backticks in issue titles, PR titles and commits(?) Mar 4, 2020
@alexanderadam
Copy link
Author

alexanderadam commented Mar 19, 2021

I don't think GitHub does support that either
image

Update: now it does.

Or how Nat put this:

kind of crazy we didn't do this before

😆

PS: They're also supporting emoji completion everywhere.

@silverwind
Copy link
Member

Yeah I actually find it quite nice that GH now does it too, so I think we can go ahead with this.

@Wuzzy2
Copy link

Wuzzy2 commented Jun 3, 2022

I support this feature. It is obviously a good thing, as it makes titles more readable. If someone implements it, please don't forget to add documentation for it, otherwise it'll be a "secret feature". :D

@yardenshoham
Copy link
Member

Does #21432 close this?

@delvh
Copy link
Member

delvh commented Nov 12, 2022

Yep, I think so.

@delvh delvh closed this as completed Nov 12, 2022
@delvh delvh added this to the 1.19.0 milestone Nov 12, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

6 participants