Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Keep edit history in local storage for backup, until applied server-side #11004

Closed
brupelo opened this issue Apr 7, 2020 · 13 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality

Comments

@brupelo
Copy link

brupelo commented Apr 7, 2020

If you don't save your issue it seems there won't be any backup or way to recover the content if you make some context change (page switching) so you'll end up losing your changes (I've experienced this few minutes ago that's why opening this issue).

It'd be awesome to achieve a similar results to github's, here's a little demo of what I mean:

showcase

@guillep2k
Copy link
Member

This could be implemented in local storage on the client side, I think.

@brupelo
Copy link
Author

brupelo commented Apr 8, 2020

@guillep2k That sounds like a great idea... I'd try to implement this feature myself by there are few limitations:

  1. I'm still trying to figure out how to build gitea on windows... ie: https://stackoverflow.com/questions/61096319/how-to-use-shell-find-on-make-for-windows
  2. I've never coded in go
  3. Even if 1&2 would be satifsfied I would need to familiarize myself with the repo so I'm not sure this would be a good "First issue" for me.

That said, I'd love to have this one implemented so hopefully someone with expertise on the repo can take this one... I titled this one as [FEATURE] but to be honest, maybe should be labelled as a bug? I mean, yesterday I've lost my issue content after 5 minutes editing and that's not cool at all, right?

Thanks in advance.

@guillep2k guillep2k added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/enhancement An improvement of existing functionality and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Apr 9, 2020
@guillep2k
Copy link
Member

  1. To build on Windows you do that from Git Bash (if you install git, it will normally include Bash). It will not work from power-shell or the old command.
  2. For this particular task I think you only need to know front-end stuff. Just check how web_src/js/index.js works. I'm more of a back-end guy, though, so I might be missing something.
  3. Only you can be the judge of that. 😄

As for labeling goes, we would consider this change an "enhancement" (you've got me confused with "feature" there for a moment 😁).

@brupelo
Copy link
Author

brupelo commented Apr 9, 2020

  1. Hehe, yeah, I know... I love working with conemu and normal shells such as command so hopefully someone will bring some light to my question here... I strongly believe we should be able to tweak the existing Makefile to make it more cross-platform so it'll work on all terminals... In any case, I must to tell you I'm not a huge fan of using Makefiles as you're just adding an extra unnecesary dependency to the project... For instance, you've got deps with node+go and you could have achieved a similar result using just node or go to write the build system.
  2. Oh, that's interesting, I'll take a look, yeah, I've got some experience coding in node... if there are other places you may recommend to take a look pls let me know, I'd like to start getting familiar with the basecode.
  3. Hehe, well... I wouldn't mind to give it a shot (I assume you guys make code reviews?) but you'd need to explain a bit how this task should be done roughly.

Enhacement... ok? Although I still think this is a bug though ;)

Ps. https://www.quora.com/What-is-the-difference-between-a-software-bug-or-defect-and-a-feature-request-improvement-or-enhancement

@guillep2k
Copy link
Member

@brupelo You say you're not very comfortable with bash and Makefile? Certainly you haven't had the exquisit experience or configuring CMake.... 😵 After using CMake for a few days you would beg for a build system written in COBOL. 🤣

@a1012112796
Copy link
Member

Hello, I thinks it's also usefull for other places which can edit messages like Pull Request , comments and so on. so maybe the title of this issue should be change. Thanks

@brupelo
Copy link
Author

brupelo commented Apr 10, 2020

@guillep2k Hehe... actually i've submited some patches to cmake in the past ;) ... Nah, seriously, don't get me wrong, I love bash et al & unix,, I tihnk unix terminals are the best thing after sliced bread. In fact, I've always missed having these type of terminals on windows. Reason why I don't use msys, cygwin, wsl et al on windows is because some of my pure win dev environment will give problems there (python, visual studio sdk, c++ and other dev tools...). So I've found using conemu + builtin windows terminals the "less bad solution".

My point is, by getting rid of unnecesary dependencies in a project and make it as cross-platform as possible is a good thing... And again, don't get me wrong, I like make when it comes to pure unix projects... and if i could compile gitea on cmd using make for windows I wouldn't have "complained" in the first place ;)

@a1012112796 Sure thing, please free to suggest a new beetter title as well as editing the initial issue to capture better the intent if you think that'll make it better.

@bryanpedini
Copy link

@brupelo

@a1012112796 Sure thing, please free to suggest a new beetter title as well as editing the initial issue to capture better the intent if you think that'll make it better.

How "Keep edit history in local storage for backup, until applied server-side", or something like that, sounds?

@brupelo brupelo changed the title [FEATURE] Issue backups while editing [FEATURE] Keep edit history in local storage for backup, until applied server-side Apr 27, 2020
@stale
Copy link

stale bot commented Jun 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Jun 26, 2020
@bryanpedini
Copy link

@stalebot shut up...
that's why I activated notifications.

Issue still to be solved (any news?)

@stale stale bot removed the issue/stale label Jun 26, 2020
@bryanpedini
Copy link

Reason why I don't use msys, cygwin, wsl et al on windows is because some of my pure win dev environment will give problems there (python, visual studio sdk, c++ and other dev tools...). So I've found using conemu + builtin windows terminals the "less bad solution".

@brupelo PS: have you thought about a VM with a Windows inception in another Windows, to develop Gitea?
(do you need / want any help either about the VM or with coding? I'm learning go right now since three months now)

@stale
Copy link

stale bot commented Aug 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 29, 2020
@zeripath zeripath added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Aug 29, 2020
@stale stale bot removed the issue/stale label Aug 29, 2020
@wxiaoguang
Copy link
Contributor

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/enhancement An improvement of existing functionality
Projects
None yet
Development

No branches or pull requests

6 participants