Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finer permission controls for users to prevent spam #1228

Open
5 tasks
pgaskin opened this issue Mar 12, 2017 · 12 comments
Open
5 tasks

Finer permission controls for users to prevent spam #1228

pgaskin opened this issue Mar 12, 2017 · 12 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Comments

@pgaskin
Copy link
Contributor

pgaskin commented Mar 12, 2017

Permissions to add:

  • Allowed to create issues
  • Allowed to create pull requests
  • Visible on user list
  • Allowed to comment on issues
  • Allowed to upload files

@lunny @bkcsoft @strk @tboerger feel free to edit this post.

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 12, 2017

Original post for future reference:

Each user should have permission settings as in:

  • Allowed to create issues
  • Allowed to create pull requests
  • Visible on user list
  • Allowed to comment on issues
  • Allowed to upload files

@lunny lunny added this to the 1.x.x milestone Mar 12, 2017
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Mar 12, 2017
@strk
Copy link
Member

strk commented Mar 12, 2017

How's "create pull-request" different from "create issues" ?
Should "Visible on user list" be a user choice rather than an admin choice ?

How about allowing creation of forks but not of repositories not being fork of other repositories ? Like with delta not bigger than a give amount of bytes and number of commits ?

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 12, 2017

@strk

How's "create pull-request" different from "create issues" ?

There are different tabs for pull requests and issues

Should "Visible on user list" be a user choice rather than an admin choice ?

It should be both because a user may want to be private, and an admin might want to hide a bot or a bad user

How about allowing creation of forks but not of repositories not being fork of other repositories ? Like with delta not bigger than a give amount of bytes and number of commits ?

Yes, that sounds good

@strk
Copy link
Member

strk commented Mar 12, 2017 via email

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 12, 2017

Ok but why would you want someone to be able to file PRs but not issues ? Or vice-versa. I'm not against it, just could be more than needed :)

For example in a company, if you do not want some employees fixing the code

Now this is where issues become suboptimal. You could either edit the original submission (with the result of the comment becomes weird) or move the plan into a wiki page maybe ? Or, we have a "proposals" repository which was created specifically for this, although it's not clearly documented how proposals should look like. Maybe could be documents like RFCs inside the "proposal" repository.

I will edit my second comment and that is where the final list will go. Feel free to edit it.

@strk
Copy link
Member

strk commented Mar 12, 2017 via email

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 12, 2017

Should this permission be per-repository then ?

Yes and also a global setting per user

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 12, 2017

@strk Should I add allowed to edit wikis?

@lunny
Copy link
Member

lunny commented Mar 13, 2017

I'm working on first step. Different team could display different tabs. See #947

@strk
Copy link
Member

strk commented Mar 13, 2017 via email

@strk
Copy link
Member

strk commented Mar 23, 2017

See also #1377 for setting limits

@stale
Copy link

stale bot commented Feb 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 16, 2019
@lunny lunny added issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented and removed issue/stale labels Feb 23, 2019
@lunny lunny removed this from the 1.x.x milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests

3 participants