Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing the language should not use GET #12403

Closed
silverwind opened this issue Aug 1, 2020 · 1 comment
Closed

Changing the language should not use GET #12403

silverwind opened this issue Aug 1, 2020 · 1 comment
Labels
issue/duplicate The issue has already been reported.

Comments

@silverwind
Copy link
Member

silverwind commented Aug 1, 2020 •
edited
Loading

Changing the language in the footer dropdown sends of a GET that potentially also writes to the database. This is non-semantic use of GET that should be eliminated. Also, the query string parameter should be removed after changing language, it's just unecessary.

Possible prerequistite for #11188.
@silverwind silverwind mentioned this issue Aug 1, 2020
Open
@techknowlogick techknowlogick added the issue/duplicate The issue has already been reported. label Aug 1, 2020
@techknowlogick
Copy link
Member

closing as dupe of #10725

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/duplicate The issue has already been reported.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@silverwind @techknowlogick